search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

add JobFailedValidation reason constant #201

Closed HeGaoYuan closed 1 year ago

HeGaoYuan commented 1 year ago

add JobFailedValidation referring to https://github.com/kubeflow/training-operator/pull/1705

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

johnugeorge commented 1 year ago

@tenzen-y @terrytangyuan Should we merge this in this release ? Ref: https://github.com/kubeflow/training-operator/pull/1705#issuecomment-1377546403

tenzen-y commented 1 year ago

@tenzen-y @terrytangyuan Should we merge this in this release ? Ref: kubeflow/training-operator#1705 (comment)

Yes, this status helps users to find a reason for errors.

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment