search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Refactor PodGroup control with more generic design #203

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

To support scheduler-plugins/coscheduling, this pr refactors the podgroup-related code.

Follow up on #185.

Part-of: https://github.com/kubeflow/training-operator/issues/1722

tenzen-y commented 1 year ago

This PR is ready for review. PTAL.

/assign @terrytangyuan @gaocegege @johnugeorge @zw0610

tenzen-y commented 1 year ago

Adapting training-operator to this feature with https://github.com/kubeflow/training-operator/pull/1724.

johnugeorge commented 1 year ago

Thanks @tenzen-y for adding this quickly before the release. I will review this in 2 days.

@zw0610 Can you also review this?

johnugeorge commented 1 year ago

Thanks @tenzen-y for his hard work

/lgtm /approve

johnugeorge commented 1 year ago

/assign @terrytangyuan

tenzen-y commented 1 year ago

@terrytangyuan I have addressed your comments. PTAL.

terrytangyuan commented 1 year ago

/lgtm /approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

@terrytangyuan @johnugeorge Can you create a new release? We need to use this feature in https://github.com/kubeflow/training-operator/pull/1724.

tenzen-y commented 1 year ago

Or will @johnugeorge work on https://github.com/kubeflow/training-operator/issues/1725 before we create a new release?