Closed tenzen-y closed 1 year ago
This PR is ready for review. PTAL.
/assign @terrytangyuan @gaocegege @johnugeorge @zw0610
Adapting training-operator to this feature with https://github.com/kubeflow/training-operator/pull/1724.
Thanks @tenzen-y for adding this quickly before the release. I will review this in 2 days.
@zw0610 Can you also review this?
Thanks @tenzen-y for his hard work
/lgtm /approve
/assign @terrytangyuan
@terrytangyuan I have addressed your comments. PTAL.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: johnugeorge, terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@terrytangyuan @johnugeorge Can you create a new release? We need to use this feature in https://github.com/kubeflow/training-operator/pull/1724.
Or will @johnugeorge work on https://github.com/kubeflow/training-operator/issues/1725 before we create a new release?
To support scheduler-plugins/coscheduling, this pr refactors the podgroup-related code.
Follow up on #185.
Part-of: https://github.com/kubeflow/training-operator/issues/1722