search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Add MaxConcurrentReconciles to JobControllerConfiguration #205

Open Syulin7 opened 1 year ago

Syulin7 commented 1 year ago

add MaxConcurrentReconciles to JobControllerConfiguration

fixes: https://github.com/kubeflow/training-operator/pull/1707#discussion_r1057075176

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval by writing /assign @terrytangyuan in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Syulin7 commented 1 year ago

@johnugeorge PTAL, I will do this in training operator once this is merged.

Syulin7 commented 1 year ago

@johnugeorge I update license, please approve running workflows, thanks.

johnugeorge commented 1 year ago

We can wait till https://github.com/kubeflow/training-operator/issues/1714 is completed. This will make it easy to make common changes

Syulin7 commented 1 year ago

ok, I agree.