kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Adding compatibility for API supporting HPA #206

Closed johnugeorge closed 1 year ago

johnugeorge commented 1 year ago

LabelSelector field is restored to provide compatibility with the current API. Instead, Selector field will be used for HPA feature

Related: #197 https://github.com/kubeflow/training-operator/issues/1725

johnugeorge commented 1 year ago

@tenzen-y Once this is merged, we can create a new release in kubeflow/common Ref: https://github.com/kubeflow/training-operator/pull/1724/files#r1080943248

tenzen-y commented 1 year ago

@johnugeorge Can you rerun hack/update-codegen.sh?

@@ -231,7 +231,7 @@ func schema_pkg_apis_common_v1_ReplicaSt
                    },
                    "selector": {
                        SchemaProps: spec.SchemaProps{
-                           Description: "A Selector is a label query over a set of resources. The result of matchLabels and matchExpressions are ANDed. An empty Selector matches all objects. A null Selector matches no objects.",
+                           Description: "A label selector is a label query over a set of resources. The result of matchLabels and matchExpressions are ANDed. An empty label selector matches all objects. A null label selector matches no objects.",
                            Type:        []string{"string"},
                            Format:      "",
                        },
./hack/../pkg is out of date. Please run hack/update-codegen.sh
tenzen-y commented 1 year ago

/lgtm cancel

tenzen-y commented 1 year ago

/lgtm

terrytangyuan commented 1 year ago

/lgtm /approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment