Closed johnugeorge closed 1 year ago
@tenzen-y Once this is merged, we can create a new release in kubeflow/common Ref: https://github.com/kubeflow/training-operator/pull/1724/files#r1080943248
@johnugeorge Can you rerun hack/update-codegen.sh
?
@@ -231,7 +231,7 @@ func schema_pkg_apis_common_v1_ReplicaSt
},
"selector": {
SchemaProps: spec.SchemaProps{
- Description: "A Selector is a label query over a set of resources. The result of matchLabels and matchExpressions are ANDed. An empty Selector matches all objects. A null Selector matches no objects.",
+ Description: "A label selector is a label query over a set of resources. The result of matchLabels and matchExpressions are ANDed. An empty label selector matches all objects. A null label selector matches no objects.",
Type: []string{"string"},
Format: "",
},
./hack/../pkg is out of date. Please run hack/update-codegen.sh
/lgtm cancel
/lgtm
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LabelSelector
field is restored to provide compatibility with the current API. Instead,Selector
field will be used for HPA featureRelated: #197 https://github.com/kubeflow/training-operator/issues/1725