search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Upgrade PriorityClass apiVersion to scheduling.k8s.io/v1 #208

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

I upgraded PriorityClass apiVersion to scheduling.k8s.io/v1 since scheduling.k8s.io/v1beta1 was removed in Kubernetes v1.22.

ref: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22

Fixes: #156

tenzen-y commented 1 year ago

@johnugeorge This PR fixes the critical bug. Can we include this in the next kubeflow/common release?

tenzen-y commented 1 year ago

/assign @gaocegege

johnugeorge commented 1 year ago

/lgtm

johnugeorge commented 1 year ago

/assign @terrytangyuan

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment