Closed Syulin7 closed 1 year ago
/lgtm
build/test was failed:
Run golangci-lint run --config=linter_config.yaml ./...
level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
Error: pkg/controller.v1/common/job_test.go:194:2: SA4017: AddDate doesn't have side effects and its return value is ignored (staticcheck)
oneDayAgo.AddDate(0, 0, -1)
^
Error: Process completed with exit code 1.
@johnugeorge @tenzen-y Do you know the reason why it happened, or can you help make it retry.
I guess the behavior of staticcheck changed since we always install the latest golangci-lint like the following:
So we need to fix the lint error. Can you fix the error?
OK, I'll give it a try.
@tenzen-y I fixed the error, can you help make it retry.
@tenzen-y I fixed the error, can you help make it retry.
Thanks for fixing the error. However, I don't have permission to approve the CI.
@kubeflow/wg-training-leads Can you approve CI?
@johnugeorge @terrytangyuan PTAL, thanks.
Thanks @Syulin7
/lgtm /approve
@terrytangyuan @gaocegege @Jeffwan PTAL, thanks.
/lgtm
@terrytangyuan Can you merge it as well?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: johnugeorge, terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Set None as default.
Fixes: https://github.com/kubeflow/training-operator/issues/1753