Closed yowenter closed 1 year ago
@yowenter And also, can you update the unit test?
https://github.com/kubeflow/common/blob/master/pkg/controller.v1/common/status_test.go
@yowenter And also, can you update the unit test?
https://github.com/kubeflow/common/blob/master/pkg/controller.v1/common/status_test.go
Hi, @tenzen-y, I've added job status unittest, please review again.
/lgtm cancel for nit
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
if pod is terminating , the pod.Status.Phase is still RUNNING. In this case, the Job status maybe not correct.