search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

fix job active count; count terminating pod as failed #214

Closed yowenter closed 1 year ago

yowenter commented 1 year ago

if pod is terminating , the pod.Status.Phase is still RUNNING. In this case, the Job status maybe not correct.

tenzen-y commented 1 year ago

@yowenter And also, can you update the unit test?

https://github.com/kubeflow/common/blob/master/pkg/controller.v1/common/status_test.go

yowenter commented 1 year ago

@yowenter And also, can you update the unit test?

https://github.com/kubeflow/common/blob/master/pkg/controller.v1/common/status_test.go

Hi, @tenzen-y, I've added job status unittest, please review again.

tenzen-y commented 1 year ago

/lgtm cancel for nit

terrytangyuan commented 1 year ago

/lgtm

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment