make createNewPod public for custom operators.

SimonCqk commented 5 years ago

For now createNewPod is a private method and used in ReconcilePods, but for customized operators, the pod reconciliation is slightly different that we may asked to maintain and update other status, so we have to override the original ReconcilePods in common lib, then createNewPod can not be reused, so I propose to make this method public.

This change is

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: terrytangyuan

If they are not already assigned, you can assign the PR to them by writing /assign @terrytangyuan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jian-he commented 5 years ago

could you give a concrete example on which part of the current reconcilePod cannot apply

johnugeorge commented 5 years ago

Instead of fixing each function by function(See #30 ), shouldn't the restructuring be done more systematically?

@richardsliu

SimonCqk commented 5 years ago

Instead of fixing each function by function(See #30 ), shouldn't the restructuring be done more systematically?

@richardsliu

Do agree, there may other cases to be ensured.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

richardsliu commented 5 years ago

@SimonCqk What is the plan for this PR? Are we creating a util class as mentioned in https://github.com/kubeflow/common/pull/30?

SimonCqk commented 5 years ago

@richardsliu It seems this PR can be closed.

kubeflow / common