search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Move JobController struct to job_controller package #51

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

It doesn't make sense to have JobController struct definition in API definition. JobController can be changed and we also provide NewJobController method for user to use, that means controller could be hided from users and implementation may changed even for same API version . It doesn't have to be changed along with api changes.

This also makes dependency graph clean for api/v1 package.

This change is Reviewable

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign gaocegege You can assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Jeffwan commented 4 years ago

/cc @gaocegege @richardsliu

Jeffwan commented 4 years ago

https://github.com/kubeflow/common/pull/55 includes the changes in this PR. I will close this one