kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Add Prometheus metrics for pod created/deleted/failed #82

Closed terrytangyuan closed 4 years ago

terrytangyuan commented 4 years ago

Not collecting metrics for pod restarted here because that requires additional changes in pod restart logic in other code. We can do that in a follow-up PR.

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

kubeflow-bot commented 4 years ago

This change is Reviewable

merlintang commented 4 years ago

/lgtm

terrytangyuan commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment