search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Skip some logics for terminated job and add PodGroup reconcile loop #93

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

Resolve #92 #94

  1. Skip checking activeDeadline or backoffLimit if job terminated
  2. Add PodGroup reconcile logic
kubeflow-bot commented 4 years ago

This change is Reviewable

ChanYiLin commented 4 years ago

/LGTM

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment