search

kubeflow / community

Information about the Kubeflow community including proposals and governance information.
Apache License 2.0
160 stars 220 forks source link

clean up calendar and remove legacy meetings #639

Closed thesuperzapper closed 1 year ago

thesuperzapper commented 1 year ago

This PR resolves https://github.com/kubeflow/community/issues/630

It also makes it more clear which meetings are active and warns users not to remove recurring meetings from the file (as this leaves them in the calendar forever).

thesuperzapper commented 1 year ago

@jbottum @juliusvonkohout @zijianjoy this PR removes meetings from the calendar which are no longer happening, I would appreciate your approval.

thesuperzapper commented 1 year ago

@akgraner just making you aware of this PR, so we can merge it before your one, to prevent removed events being re-added.

juliusvonkohout commented 1 year ago

/lgtm

juliusvonkohout commented 1 year ago

i did not check every detail but /lgtm

juliusvonkohout commented 1 year ago

/assign @zijianjoy

akgraner commented 1 year ago

@akgraner just making you aware of this PR, so we can merge it before your one, to prevent removed events being re-added.

@thesuperzapper thank you! Let me know when this get's merged then I'll send over my updates.

thesuperzapper commented 1 year ago

@chensun the reordering (and docs update) is the main point of the PR, as it makes it easier to see which are the "current meetings" and also warns users about how the file actually works at the top.

The only meeting "change" is setting the until (end-date) for the Kubeflow Feature Store SIG Meeting (US/Asia friendly) meeting, which has not been happening for many years, as seen in https://github.com/kubeflow/community/issues/630.

PS: I have rebased it after you merged https://github.com/kubeflow/community/pull/641, but would appreciate merging this now so we don't have to rebase again.

thesuperzapper commented 1 year ago

The only other "change" is that I removed the until date of:

As they don't need an end-date (which is probably why the diff is confusing), because we can reschedule them if we need to in the future, rather than having a random end-date decided in advance.

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chensun, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[calendar/OWNERS](https://github.com/kubeflow/community/blob/master/calendar/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment