search

kubeflow / community

Information about the Kubeflow community including proposals and governance information.
Apache License 2.0
160 stars 220 forks source link

Guidelines to update release OWNERS file #728

Closed StefanoFioravanzo closed 5 months ago

StefanoFioravanzo commented 5 months ago

The release folder OWNERS file was left stale. We need to allow the release manager and the release team to independently amend the release handbook and update the release folder when necessary.

Also, update the OWNERS file to reflect the current team and add previous release managers as emeritus approvers.

StefanoFioravanzo commented 5 months ago

cc @rimolive @kubeflow/kubeflow-steering-committee

StefanoFioravanzo commented 5 months ago

Seems like we have some members of the release team who are not part of the org 🙃

The major point here is to update the approvers and document the process to update the OWNERS file, so I'll remove them for now to expedite merging this PR.

@diegolovison @stevei101 @milosjava please add yourself to the org if you want to be included!

rimolive commented 5 months ago

Seems like we have some members of the release team who are not part of the org 🙃

The major point here is to update the approvers and document the process to update the OWNERS file, so I'll remove them for now to expedite merging this PR.

@diegolovison @stevei101 @milosjava please add yourself to the org if you want to be included!

This looks inaccurate.

https://github.com/kubeflow/internal-acls/blob/master/github-orgs/kubeflow/org.yaml#L112 << Diego membership

milosjava commented 5 months ago

@StefanoFioravanzo ok I've created PR for adding me to the org. https://github.com/kubeflow/internal-acls/pull/684

StefanoFioravanzo commented 5 months ago

This looks inaccurate.

I wonder why GitHub reported him as an untrusted user then..

Anyway, let's focus on merging the new guidelines and the first revision of the OWNERS file. We can add them later.

cc @andreyvelich can you approve?

terrytangyuan commented 5 months ago

/lgtm /approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[releases/OWNERS](https://github.com/kubeflow/community/blob/master/releases/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment