search

kubeflow / dashboard

Kubeflow Central Dashboard is the web interface for Kubeflow
Apache License 2.0
3 stars 2 forks source link

[Profile] Allow containers/pods without resources #21

Open gkcalat opened 1 year ago

gkcalat commented 1 year ago

/kind feature

Why you need this feature:

Profile allows to set resources quota per namespace. When enabled, containers with empty resources spec will fail.

This is affecting Kubeflow Pipelines. Argo uses workflow-controller-configmap that can overwrite resources for executor containers. It was patched with arbitrary values in kubeflow/pipelines#5695, but we reverted it in kubeflow/pipelines#9089 as it was preventing users from specifying their resources spec for pipeline containers. So, the upcoming releases of KFP will allow containers with empty resources.

Describe the solution you'd like:

Example:

  1. Allow users to set default resources in Profile
  2. Patch containers with empty resources using default values from the associated Profile (or use limits if defaults are missing)

Anything else you would like to add: Related: kubeflow/kubeflow#7077

andreyvelich commented 1 week ago

/transfer dashboard

google-oss-prow[bot] commented 1 week ago

@gkcalat: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubeflow/dashboard/issues/21): >/kind feature > > >**Why you need this feature:** > >`Profile` allows to set resources quota per namespace. When enabled, containers with empty `resources` spec will fail. > >This is affecting Kubeflow Pipelines. Argo uses `workflow-controller-configmap` that can overwrite `resources` for executor containers. It was patched with arbitrary values in kubeflow/pipelines#5695, but we reverted it in kubeflow/pipelines#9089 as it was [preventing users](https://github.com/kubeflow/pipelines/issues/9087) from specifying their `resources` spec for pipeline containers. So, the upcoming releases of KFP will allow containers with empty `resources`. > >**Describe the solution you'd like:** > >Example: >1. Allow users to set default resources in `Profile` >2. Patch containers with empty `resources` using default values from the associated `Profile` (or use limits if defaults are missing) > >**Anything else you would like to add:** >Related: kubeflow/kubeflow#7077 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.