search

kubeflow / dashboard

Kubeflow Central Dashboard is the web interface for Kubeflow
Apache License 2.0
3 stars 2 forks source link

BUILD_VERSION is not correctly shown in the UI #25

Open capkurmagati opened 1 year ago

capkurmagati commented 1 year ago

/kind bug

What steps did you take and what happened: The BUILD_VERSION is not set in the centeraldashboard docker image. https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/Dockerfile#L6 Because the kubeflowversion arg is not set in the Makefile. https://github.com/kubeflow/kubeflow/blob/c946c624cd8974ef53cac04582e4714b466d546e/components/centraldashboard/Makefile#L33-L40

The UI falls back to use dev_local. https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/webpack.config.js#L22

What did you expect to happen: BUILD_VERSION is set and correctly shown on the central dashboard UI.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

andreyvelich commented 1 week ago

/transfer dashboard

google-oss-prow[bot] commented 1 week ago

@capkurmagati: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubeflow/dashboard/issues/25): >/kind bug > >**What steps did you take and what happened:** >The `BUILD_VERSION` is not set in the centeraldashboard docker image. >https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/Dockerfile#L6 >Because the `kubeflowversion` arg is not set in the Makefile. >https://github.com/kubeflow/kubeflow/blob/c946c624cd8974ef53cac04582e4714b466d546e/components/centraldashboard/Makefile#L33-L40 > >The UI falls back to use `dev_local`. >https://github.com/kubeflow/kubeflow/blob/65298ad04daa6cc1c1dfbb9dc99f2c1ab3bfd99d/components/centraldashboard/webpack.config.js#L22 > > >**What did you expect to happen:** >`BUILD_VERSION` is set and correctly shown on the central dashboard UI. > >**Anything else you would like to add:** >[Miscellaneous information that will assist in solving the issue.] > > >**Environment:** > >- Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard): >- kfctl version: (use `kfctl version`): >- Kubernetes platform: (e.g. `minikube`) >- Kubernetes version: (use `kubectl version`): >- OS (e.g. from `/etc/os-release`): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.