kubeflow / dashboard

Kubeflow Central Dashboard is the web interface for Kubeflow
Apache License 2.0
3 stars 2 forks source link

Add annotation to namespace from profile CRD #47

Open mareksimunek opened 1 year ago

mareksimunek commented 1 year ago

/kind question

Question: Hi, I want to add annotation to a namespace created by kubeflow Profiles. If I looked correctly its not possible, only annotations added to a namespace is the owner of the profile.

https://github.com/kubeflow/kubeflow/blob/b922fa1573e4f0d19548f5ea94dbe3f78826bfed/components/profile-controller/controllers/profile_controller.go#L129

So with:

apiVersion: kubeflow.org/v1beta1
kind: Profile
metadata:
  name: test
spec:
  owner:
    kind: User
    name: user@test.com

Namespace created is:

>kubectl describe namespace test
Name:         test
Labels:       app.kubernetes.io/part-of=kubeflow-profile
              istio-injection=enabled
              katib.kubeflow.org/metrics-collector-injection=enabled
              kubernetes.io/metadata.name=test
              pipelines.kubeflow.org/enabled=true
              serving.kubeflow.org/inferenceservice=enabled
Annotations:  owner: user@test.com

Motivation:

We want to have several nodes in cluster dedicated to production workload and with annotation on namespace

> kubectl describe namespace production
Name:         production
Annotations: 
              scheduler.alpha.kubernetes.io/node-selector: workset=production

we are able to separete production and research experimentation workloads.

Am I missing something or its a thing for contribution?

andreyvelich commented 2 weeks ago

/transfer dashboard

google-oss-prow[bot] commented 2 weeks ago

@mareksimunek: The label(s) kind/question cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubeflow/dashboard/issues/47): >/kind question > >**Question:** >Hi, I want to add annotation to a namespace created by kubeflow Profiles. If I looked correctly its not possible, only annotations added to a namespace is the owner of the profile. > >https://github.com/kubeflow/kubeflow/blob/b922fa1573e4f0d19548f5ea94dbe3f78826bfed/components/profile-controller/controllers/profile_controller.go#L129 > >So with: >``` >apiVersion: kubeflow.org/v1beta1 >kind: Profile >metadata: > name: test >spec: > owner: > kind: User > name: user@test.com >``` > >Namespace created is: >``` >>kubectl describe namespace test >Name: test >Labels: app.kubernetes.io/part-of=kubeflow-profile > istio-injection=enabled > katib.kubeflow.org/metrics-collector-injection=enabled > kubernetes.io/metadata.name=test > pipelines.kubeflow.org/enabled=true > serving.kubeflow.org/inferenceservice=enabled >Annotations: owner: user@test.com >``` > >Motivation: > >We want to have several nodes in cluster dedicated to production workload and with annotation on namespace >``` >> kubectl describe namespace production >Name: production >Annotations: > scheduler.alpha.kubernetes.io/node-selector: workset=production >``` >we are able to separete production and research experimentation workloads. > >Am I missing something or its a thing for contribution? > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.