search

kubeflow / dashboard

Kubeflow Central Dashboard is the web interface for Kubeflow
Apache License 2.0
3 stars 2 forks source link

Propagate labels from `profile` custom resource to controller-generated namespace #51

Open droctothorpe opened 9 months ago

droctothorpe commented 9 months ago

/kind feature

Why you need this feature: We use the profile operator directly instead of pathing through the UI. We want end user namespaces to have specific labels (that identify various things about the user). This code lets administrators set global namespace labels, but there's no mechanism to pass custom-resource-specific, non-global labels.

Describe the solution you'd like: The simplest way to implement this is to just propagate labels from the profile custom resource to the corresponding namespace. It's a one line change to the controller logic.

Anything else you would like to add: I'll submit a PR momentarily.

andreyvelich commented 1 week ago

/transfer dashboard

google-oss-prow[bot] commented 1 week ago

@droctothorpe: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubeflow/dashboard/issues/51): >/kind feature > >**Why you need this feature:** >We use the profile operator directly instead of pathing through the UI. We want end user namespaces to have specific labels (that identify various things about the user). [This code](https://github.com/kubeflow/kubeflow/blob/master/components/profile-controller/controllers/profile_controller.go#L137) lets administrators set **global** namespace labels, but there's no mechanism to pass custom-resource-specific, non-global labels. > >**Describe the solution you'd like:** >The simplest way to implement this is to just propagate labels from the `profile` custom resource to the corresponding namespace. It's a one line change to the controller logic. > >**Anything else you would like to add:** >I'll submit a PR momentarily. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.