search

kubeflow / examples

A repository to host extended examples and tutorials
Apache License 2.0
1.4k stars 753 forks source link

Update the examples with correct image paths and packages #1016

Closed kimwnasptd closed 1 year ago

kimwnasptd commented 1 year ago

Some of the examples had issues with

  1. The images would not get rendered correctly, due to jupyter not parsing query params correctly
  2. The Kale image was explicitly set in the notebook metadata
  3. Some packages needed some updates

cc @akgraner @jimmyguerrero

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

akgraner commented 1 year ago

Thank you for your contribution! /lgtm /approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akgraner, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/examples/blob/master/OWNERS)~~ [akgraner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment