kubeflow / examples

A repository to host extended examples and tutorials
Apache License 2.0
1.4k stars 753 forks source link

Example of converting Store Sales Forecast Kaggle notebook to a Kubeflow pipeline #994

Closed NeoKish closed 1 year ago

NeoKish commented 2 years ago

/assign @kimwnasptd /assign @js-ts /assign @jinchihe

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jbottum commented 2 years ago

@NeoKish thanks for this documentation and tutorial update. A few questions. Does this run on KF 1.6 ? This tutorial uses Kale. Does Kale require Rok ?

NeoKish commented 2 years ago

@jbottum, thanks for the comment. So I am using Arrikto's KFaaS. The Kubeflow version is 1.4 based on the latest release. Yes Kale does have dependency on Rok.

kimwnasptd commented 1 year ago

Took a look at the code of the example

/lgtm

akgraner commented 1 year ago

Thank you for your contribution!

/approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akgraner, NeoKish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/examples/blob/master/OWNERS)~~ [akgraner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment