Closed mochiliu3000 closed 4 years ago
Hi @mochiliu3000. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@mochiliu3000 Please fix the beflow lint problem in kubeflow/fairing/builders/podman/podman.py
, thanks.
INFO|2020-03-06T06:54:05|util.py:72| ************* Module kubeflow.fairing.builders.podman.podman
INFO|2020-03-06T06:54:05|util.py:72| C: 44, 0: Line too long (110/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 64, 0: Line too long (102/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 74, 0: Line too long (109/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 80, 0: Line too long (104/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 83, 0: Final newline missing (missing-final-newline)
INFO|2020-03-06T06:54:05|util.py:72| W: 1, 0: Unused import json (unused-import)
@jinchihe Following your requirements, I've updated the PR and also added a test case: test_podman.py. Please kindly help review it, thanks.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jinchihe
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: Environments like OCP 4 use CRI-O as default container runtime. In order to submit jobs to such environment, need to support podman builder to build image and push image to CRI-O based registry with/without TLS checking.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #472Special notes for your reviewer:
Release note:
This change is