kubeflow / fairing

Python SDK for building, training, and deploying ML models
Apache License 2.0
337 stars 144 forks source link

Add podman builder to support CRI-O runtime #474

Closed mochiliu3000 closed 4 years ago

mochiliu3000 commented 4 years ago

What this PR does / why we need it: Environments like OCP 4 use CRI-O as default container runtime. In order to submit jobs to such environment, need to support podman builder to build image and push image to CRI-O based registry with/without TLS checking.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #472

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


This change is Reviewable

k8s-ci-robot commented 4 years ago

Hi @mochiliu3000. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jinchihe commented 4 years ago

/ok-to-test

jinchihe commented 4 years ago

@mochiliu3000 Please fix the beflow lint problem in kubeflow/fairing/builders/podman/podman.py, thanks.

INFO|2020-03-06T06:54:05|util.py:72| ************* Module kubeflow.fairing.builders.podman.podman
INFO|2020-03-06T06:54:05|util.py:72| C: 44, 0: Line too long (110/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 64, 0: Line too long (102/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 74, 0: Line too long (109/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 80, 0: Line too long (104/100) (line-too-long)
INFO|2020-03-06T06:54:05|util.py:72| C: 83, 0: Final newline missing (missing-final-newline)
INFO|2020-03-06T06:54:05|util.py:72| W:  1, 0: Unused import json (unused-import)
mochiliu3000 commented 4 years ago

@jinchihe Following your requirements, I've updated the PR and also added a test case: test_podman.py. Please kindly help review it, thanks.

屏幕快照 2020-03-24 下午8 28 29
jinchihe commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)~~ [jinchihe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment