Support IBM cloud as backend

kubeflow / fairing

Python SDK for building, training, and deploying ML models

Apache License 2.0

337 stars 144 forks source link

Support IBM cloud as backend #479

Closed jinchihe closed 4 years ago

jinchihe commented 4 years ago

What this PR does / why we need it: Support ibm cloud

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #469

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

This change is

jinchihe commented 4 years ago

/assign @Tomcli

Would you please take a look? thanks @Tomcli By the way, I will update mnist example for IBM Cloud once the PR merged.

/cc @animeshsingh

jinchihe commented 4 years ago

@Tomcli Thanks for the reviewing. Addressed your comments. OK, will do that once get chance. Thanks.

Tomcli commented 4 years ago

/lgtm

jinchihe commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)~~ [jinchihe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment