kubeflow / fairing

Python SDK for building, training, and deploying ML models
Apache License 2.0
337 stars 144 forks source link

Add example notebook stitching together BentoML and Fairing #497

Closed iancoffey closed 4 years ago

iancoffey commented 4 years ago

What this PR does / why we need it:

I find the use cases around the combo of BentoML and KF pretty interesting, so I made this little experiment notebook to flesh out these ideas. Now that it is done, I thought my experiment notebook might make a good example for this project. I trained a Prophet model with covid19 time-series data for the experiment and then stitched the BentoML artifacts to Fairings Cluster builder.

I was also thinking about extending the end of the notebook to use KFServing instead of directly creating pods for the model apis, and contributing this instead to the kf-examples repo.

Im very interested in folks thoughts in general, cheers.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jinchihe You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubeflow-bot commented 4 years ago

This change is Reviewable

iancoffey commented 4 years ago

Im going to take my own suggestion and close and reopen after updating the deploy.