search

kubeflow / fairing

Python SDK for building, training, and deploying ML models
Apache License 2.0
337 stars 144 forks source link

Add documentation for dependency installation feature #517

Open yashjakhotiya opened 4 years ago

yashjakhotiya commented 4 years ago

What this PR does / why we need it: Without documentation, users might struggle in installation of additional python packages in the built docker image required for fairing jobs. This PR mentions the special role of 'requirements.txt' in input_files list of ml_tasks.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #NONE

Special notes for your reviewer:

This is a documentation update PR

Release note:

NONE
kubeflow-bot commented 4 years ago

This change is Reviewable

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jinchihe You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 years ago

Hi @yashjakhotiya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yashjakhotiya commented 4 years ago

/assign @jinchihe

jinchihe commented 4 years ago

/ok-to-test

jinchihe commented 4 years ago

/retest

yashjakhotiya commented 4 years ago

@jinchihe this is only a documentation update. Ideally, this should not fail any presubmit test.

jinchihe commented 4 years ago

@jinchihe this is only a documentation update. Ideally, this should not fail any presubmit test.

Yeah, that should be caused by test tenv, I will take a look later once get chance. Thanks.

jinchihe commented 4 years ago

/retest

k8s-ci-robot commented 4 years ago

@yashjakhotiya: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-fairing-presubmit 0505b25e0728a892768340a56f159a0b55fd0cd8 link /test kubeflow-fairing-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jinchihe commented 4 years ago

@yashjakhotiya The CI testing problem has been fixed, would you please fetch and rebase? thanks a lot!