search

kubeflow / fairing

Python SDK for building, training, and deploying ML models
Apache License 2.0
337 stars 144 forks source link

Update OWNERS #518

Closed jinchihe closed 4 years ago

jinchihe commented 4 years ago

From @jlewi

A couple of things to call out for people who have been discussing forming WGs in various areas.

Please take a look at the roles defined for each WG and think about who you would want to assume those roles

Please think about ensuring your OWNERs files are up to date and adequately reflect who the OWNERs are for various sub projects. This will be critical to ensuring OWNERs don't get overlooked.

Update OWINERS, remove some inactive owners, and add @xauthulei who has some contributors to review code, thanks.

kubeflow-bot commented 4 years ago

This change is Reviewable

jinchihe commented 4 years ago

@abhi-g @karthikv2k @r2d4 The PR will keep couple of days, please append if you want to keep in the OWNERS list. Thanks!

abhi-g commented 4 years ago

@jinchihe please feel free to remove me from owners.

Thanks for your continued contributions to Fairing.

On Sat, Jun 27, 2020 at 11:42 PM Kubernetes Prow Robot < notifications@github.com> wrote:

@jinchihe https://github.com/jinchihe: The following test failed, say /retest to rerun all failed tests: Test name Commit Details Rerun command kubeflow-fairing-presubmit 79d3e37 https://github.com/kubeflow/fairing/commit/79d3e37fad83244e746b0381ea199d785b859d5b link https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_fairing/518/kubeflow-fairing-presubmit/1277121994042642432/ /test kubeflow-fairing-presubmit

Full PR test history https://prow.k8s.io/pr-history?org=kubeflow&repo=fairing&pr=518. Your PR dashboard. Please help us cut down on flakes by linking to https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests an open issue https://github.com/kubeflow/fairing/issues?q=is:issue+is:open when you hit one in your PR.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/guide/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository. I understand the commands that are listed here https://go.k8s.io/bot-commands.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/kubeflow/fairing/pull/518#issuecomment-650705943, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZ2UZSABXWRKLY74GYJP6LRY3Q5JANCNFSM4OKL6Q4Q .

jlewi commented 4 years ago

@jinchihe We should probably have a minimum of 2-3 approvers just so we have a backup for emergencies. If there isn't an active contributor who would make sense for this then the next best thing would be to add someone who can be trusted to only approve PRs in an emergency.

Any suggestions?

jinchihe commented 4 years ago

@jlewi Thanks! Agree with you, if so, I think we can add @xauthulei as approver. Please let me know if you think we should add others.

jlewi commented 4 years ago

@jinchihe Sounds good to me

xauthulei commented 4 years ago

/lgtm

Thanks

jinchihe commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)~~ [jinchihe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment