search

kubeflow / fairing

Python SDK for building, training, and deploying ML models
Apache License 2.0
337 stars 144 forks source link

Fix bug for V1alpha2TensorRTSpec ImportError #522

Closed jinchihe closed 4 years ago

jinchihe commented 4 years ago

What this PR does / why we need it: Fix bug for V1alpha2TensorRTSpec ImportError

 from kfserving import V1alpha2TensorRTSpec
ImportError: cannot import name 'V1alpha2TensorRTSpec'

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubeflow/examples/issues/806

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

kubeflow-bot commented 4 years ago

This change is Reviewable

jinchihe commented 4 years ago

Seems the new cloudpickle has some problem, we pined to old one. Thanks

Step #2: >       assert expected_result in captured.out
Step #2: E       assert '4fa710a7-4a86-4a3e-8a97-0fb07e9cf916' in 'Traceback (most recent call last):\n  File "/app/function_shim.py", li
ne 2, in <module>\n    import cloudpickle\n  Fi...", line 57, in <module>\n    from .compat import pickle\nModuleNotFoundError: No module
 named \'cloudpickle.compat\'\n'
Step #2: E        +  where 'Traceback (most recent call last):\n  File "/app/function_shim.py", line 2, in <module>\n    import cloudpick
le\n  Fi...", line 57, in <module>\n    from .compat import pickle\nModuleNotFoundError: No module named \'cloudpickle.compat\'\n' = Capt
ureResult(out='Traceback (most recent call last):\n  File "/app/function_shim.py", line 2, in <module>\n    import...7, in <module>\n
from .compat import pickle\nModuleNotFoundError: No module named \'cloudpickle.compat\'\n', err='').out
xauthulei commented 4 years ago

/lgtm Thanks @jinchihe

jinchihe commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)~~ [jinchihe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment