Add importing yaml library on mnist_e2e_on_prem.ipynb (#553)

kubeflow / fairing

Python SDK for building, training, and deploying ML models

Apache License 2.0

337 stars 144 forks source link

Add importing yaml library on mnist_e2e_on_prem.ipynb (#553) #555

Open kwonmha opened 3 years ago

kwonmha commented 3 years ago

What this PR does / why we need it: Added missing import yaml statement.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #553

Special notes for your reviewer:

Let me know if I should add release notes.

Release note:

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwonmha To complete the pull request process, please assign jinchihe after the PR has been reviewed. You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kwonmha commented 3 years ago

Thx @xauthulei . Added \n.

xauthulei commented 3 years ago

/lgtm

@jinchihe , it seems the Travis CI have some issue, would you check it please. Thanks