kubeflow / fairing

Python SDK for building, training, and deploying ML models
Apache License 2.0
337 stars 144 forks source link

add config size information in the append builder to support image pull in a podman environment #569

Open choismn00 opened 2 years ago

choismn00 commented 2 years ago

What this PR does / why we need it: When trying to pull an image built by append builder using podman, blob size mismatch error occurs. This is due to config size mismatch in manifest.

current append builder only appends a new layer and updates config digest in the manifest. so the config size of the newly built image manifest remains the same of that of the base image used to build a new image. This doesn't seem to be a problem when trying to pull an image using docker but when trying to pull an image using podman, size mismatch error occurs.

This PR added a code to add config size information in the manifest.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #568

Special notes for your reviewer:

Release note:

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: choismn00 To complete the pull request process, please assign jinchihe after the PR has been reviewed. You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/fairing/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment