search

kubeflow / internal-acls

Repository used to main group ACLs used by Kubeflow developers
Apache License 2.0
15 stars 326 forks source link

Add droctothorpe as member #657

Closed droctothorpe closed 8 months ago

droctothorpe commented 8 months ago

Closed this issue in favor of this PR. There are some conflicting instructions on the website vs the readme here / community repo.

Please provide links to PRs or other contributions (2-3):

Please list 2 existing members who are sponsoring your membership: @connor-mccarthy @andreyvelich

Please test your PR

Run

cd github_orgs
pytest test_org_yaml.py

Include the output in the PR

===================================================================================== test session starts =====================================================================================
platform darwin -- Python 3.11.4, pytest-7.4.3, pluggy-1.0.0
rootdir: /Users/inn487/code/kubeflow/internal-acls/github-orgs
plugins: anyio-4.0.0, cov-4.1.0
collected 1 item

test_org_yaml.py .                                                                                                                                                                      [100%]

====================================================================================== 1 passed in 0.11s ======================================================================================
google-oss-prow[bot] commented 8 months ago

Hi @droctothorpe. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
james-jwu commented 8 months ago

/lgtm /approve

andreyvelich commented 8 months ago

@droctothorpe Please sign your commit for DCO.

droctothorpe commented 8 months ago

@droctothorpe Please sign your commit for DCO.

Thanks, @andreyvelich. Fixed! 👍

andreyvelich commented 8 months ago

Great, thanks @droctothorpe! /lgtm /approve

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, droctothorpe, james-jwu, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/internal-acls/blob/master/OWNERS)~~ [andreyvelich,james-jwu,terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment