search

kubeflow / internal-acls

Repository used to main group ACLs used by Kubeflow developers
Apache License 2.0
15 stars 326 forks source link

Add diegolovison as member to kubeflow org #659

Closed diegolovison closed 8 months ago

diegolovison commented 8 months ago

Provide 2-3 links to PRs or other contributions. Remove outdated versions of Kubernetes: https://github.com/kubeflow/manifests/pull/2640 Add steps to install Kubeflow on kind: https://github.com/kubeflow/manifests/pull/2634

List 2 existing members who are sponsoring your membership. @hbelmiro @rimolive

Test your PR by running the following:

$ pytest test_org_yaml.py
/home/dlovison/miniconda3/envs/ods-ci/lib/python3.11/site-packages/pytest_logger/plugin.py:104: PytestDeprecationWarning: The hookimpl LoggerPlugin.pytest_runtest_makereport uses old-style configuration options (marks or attributes).
Please use the pytest.hookimpl(hookwrapper=True) decorator instead
 to configure the hooks.
 See https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers
  @pytest.mark.hookwrapper
========================================================================================================= test session starts ==========================================================================================================
platform linux -- Python 3.11.5, pytest-7.4.2, pluggy-1.3.0
rootdir: /home/dlovison/github/kubeflow/internal-acls/github-orgs
plugins: logger-0.5.1
collected 1 item                                                                                                                                                                                                                       

test_org_yaml.py .                                                                                                                                                                                                               [100%]

========================================================================================================== 1 passed in 0.06s ===========================================================================================================
google-oss-prow[bot] commented 8 months ago

Hi @diegolovison. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rimolive commented 8 months ago

/lgtm

I am sponsoring Diego's membership

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diegolovison, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/internal-acls/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment