Open lampajr opened 6 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lampajr Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @lampajr. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
I tested the workflow locally using act
:
gh act -j tests
and this is an extract from the output:
| ============================= test session starts ==============================
| platform linux -- Python 3.10.13, pytest-8.2.0, pluggy-1.5.0
| rootdir: /home/alampare/kubeflow/internal-acls/github-orgs
| plugins: asyncio-0.23.6
| asyncio: mode=strict
collected 1 item
|
| test_org_yaml.py . [100%]
|
| ============================== 1 passed in 0.20s ===============================
[Github Org Tests/tests] ✅ Success - Main Run tests
[Github Org Tests/tests] ⭐ Run Post Set up Python 3.10
...
[Github Org Tests/tests] ✅ Success - Post Set up Python 3.10
[Github Org Tests/tests] Cleaning up container for job tests
[Github Org Tests/tests] 🏁 Job succeeded
/ok-to-test
As highlighted here, currently there is no test automation, thus requiring users to run those tests locally and report the result in the PR. With this change I am proposing a simple GitHub workflow to automatically trigger GitHub org tests on pull request creation.
This will remove, from user perspective, the need to run those tests locally and report results in the PR itself.