kubeflow / internal-acls

Repository used to main group ACLs used by Kubeflow developers
Apache License 2.0
15 stars 326 forks source link

Update org.yaml #679

Closed franciscojavierarceo closed 5 months ago

franciscojavierarceo commented 5 months ago

Adding @franciscojavierarceo as a contributor

Completed Steps

[patch-1]% pytest test_org_yaml.py
=============================================================================================== test session starts ================================================================================================
platform darwin -- Python 3.9.19, pytest-7.4.4, pluggy-1.5.0
benchmark: 3.4.1 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /Users/farceo/dev/internal-acls/github-orgs
plugins: benchmark-3.4.1, cov-5.0.0, anyio-4.3.0, typeguard-4.2.1, env-1.1.3, ordering-0.6, mock-1.10.4, timeout-1.4.2, lazy-fixture-0.6.3, xdist-3.6.1
collected 1 item

test_org_yaml.py .                                                                                                                                                                                           [100%]

================================================================================================ 1 passed in 0.13s =================================================================================================

And here's a screenshot of the 59 contribution count Screenshot 2024-05-09 at 10 31 58 AM

google-oss-prow[bot] commented 5 months ago

Hi @franciscojavierarceo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
franciscojavierarceo commented 5 months ago

@terrytangyuan updated!

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/internal-acls/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andreyvelich commented 5 months ago

Thank you for all of your contribution @franciscojavierarceo to the Kubeflow community! I am happy to sponsor this request. /lgtm