kubeflow / internal-acls

Repository used to main group ACLs used by Kubeflow developers
Apache License 2.0
15 stars 326 forks source link

Add ederign as member #681

Closed thesuperzapper closed 5 months ago

thesuperzapper commented 5 months ago

This PR adds @ederign as a member.

He is a Red Hat employee that is assigned to Kubeflow.

He has been contributing significantly to the Notebooks 2.0 work (https://github.com/kubeflow/kubeflow/issues/7156), and we would like to add him as a reviewer in some sub-directory of the new kubeflow/notebooks repo, so he needs to be a member of the org.

He is also a mentor for the GSOC Kubeflow Notebook 2.0 project.

Most of his contributions are currently non-code (designing UI for Noteoboks 2.0), but I expect this will change, here is is current first PR:

thesuperzapper commented 5 months ago

@kimwnasptd can you please act as a second reference.

thesuperzapper commented 5 months ago

@tarilabs and @rareddy can confirm that @ederign is a current Red Hat employee and can be trusted to have membership.

rareddy commented 5 months ago

@ederign +1 for adding Eder to Kubeflow.

thesuperzapper commented 5 months ago

I realized I forgot to add him to the @kubeflow/red-hat team, so I have done that in https://github.com/kubeflow/internal-acls/pull/681/commits/4449871928fe930bfa047378d76d5083455c564d

rimolive commented 5 months ago

/lgtm

thesuperzapper commented 5 months ago

@andreyvelich I think we are good to merge this with your approval.

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/internal-acls/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment