search

kubeflow / internal-acls

Repository used to main group ACLs used by Kubeflow developers
Apache License 2.0
15 stars 329 forks source link

add ImpSy as member of the kubeflow org #715

Closed ImpSy closed 1 month ago

ImpSy commented 1 month ago

Being added as a reviewer on kubeflow/spark-operator

https://github.com/kubeflow/spark-operator/pull/2235

Contributions

https://github.com/kubeflow/spark-operator/pulls?q=sort%3Aupdated-desc+is%3Apr+author%3AImpSy

Sponsoring members

Yi Chen @ChenYi015 Jacob Salway @jacobsalway

Pytest output

pytest test_org_yaml.py
============================================== test session starts ===============================================
platform darwin -- Python 3.10.15, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/sebastien.maintrot/Sandbox/internal-acls/github-orgs
collected 1 item

test_org_yaml.py .                                                                                         [100%]

=============================================== 1 passed in 0.08s ================================================
google-oss-prow[bot] commented 1 month ago

Hi @ImpSy. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yuchaoran2011 commented 1 month ago

/lgtm

ChenYi015 commented 1 month ago

/lgtm /ok-to-test

andreyvelich commented 1 month ago

Thank you for your great contributions @ImpSy! /lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/internal-acls/blob/master/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment