search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.49k stars 439 forks source link

Conda package #1410

Open thomas-mueller opened 3 years ago

thomas-mueller commented 3 years ago

/kind feature

In addition to the existing pip package it would be nice to publish a conda package. Such packages already exist for other parts of kubeflow, e.g. pipelines.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

andreyvelich commented 3 years ago

/lifecycle frozen

iamthebot commented 8 months ago

Reopening this. I'm taking a stab at a conda-forge feedstock today.

andreyvelich commented 7 months ago

/good-first-issue

iamthebot commented 7 months ago

Thanks for the ping. @andreyvelich would you be willing to be listed as a maintainer? It only involves merging an auto-generated PR when a new version is released on pypi.

WIP PR is here

andreyvelich commented 7 months ago

Thank you for creating this @iamthebot! It would be nice to update Katib SDK README on how we should auto-generate PR for a new version: https://github.com/kubeflow/katib/tree/master/sdk/python/v1beta1#publish-new-sdk-version-to-pypi

you be willing to be listed as a maintainer?

Absolutely, please also add @johnugeorge @tenzen-y. @droctothorpe Do you want to be part of maintainer list for conda package ?

It would be great to publish Training Operator SDK to conda as well: https://github.com/kubeflow/training-operator/tree/master/sdk/python

iamthebot commented 7 months ago

@andreyvelich that's the neat thing, once this PR (adding kubeflow-katib) is merged we'll get a new repo in the conda-forge org. Conda-forge's build system will automatically create a new PR tagging the maintainers whenever you publish a new version in pypi. No need to trigger generation yourself.

I'll go ahead and add those folks as maintainers.

Once this PR is ready to go I'll work on one for training operator SDK. I'll make a new issue on that repo to track the conda packaging effort.

droctothorpe commented 7 months ago

Thank you for creating this @iamthebot! It would be nice to update Katib SDK README on how we should auto-generate PR for a new version: https://github.com/kubeflow/katib/tree/master/sdk/python/v1beta1#publish-new-sdk-version-to-pypi

you be willing to be listed as a maintainer?

Absolutely, please also add @johnugeorge @tenzen-y. @droctothorpe Do you want to be part of maintainer list for conda package ?

It would be great to publish Training Operator SDK to conda as well: https://github.com/kubeflow/training-operator/tree/master/sdk/python

Sure thing and +1 to publishing the training SDK to conda.

iamthebot commented 7 months ago

@droctothorpe @andreyvelich @johnugeorge @tenzen-y please leave a comment on this PR indicating that you are willing to be listed as a maintainer for the katib conda package. The conda-forge PR cannot be merged otherwise. Thanks.

Sure thing and +1 to publishing the training SDK to conda.

Yep, will make a new PR in a few minutes for the training SDK.

tenzen-y commented 7 months ago

@iamthebot Thanks for your work. /remove-good-first-issue /remove-help

tenzen-y commented 7 months ago

/assign @iamthebot

iamthebot commented 7 months ago

@tenzen-y conda package is published. Can we close this issue?

tenzen-y commented 7 months ago

@tenzen-y conda package is published. Can we close this issue?

@iamthebot Sure, thank you for this effort! /close

google-oss-prow[bot] commented 7 months ago

@tenzen-y: Closing this issue.

In response to [this](https://github.com/kubeflow/katib/issues/1410#issuecomment-1977828935): >> @tenzen-y conda package [is published](https://anaconda.org/conda-forge/kubeflow-katib). Can we close this issue? > >@iamthebot Sure, thank you for this effort! >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andreyvelich commented 7 months ago

Thank you for adding Conda package @iamthebot! Please can update the README to explain how we should publish a new release to Conda: https://github.com/kubeflow/katib/tree/master/sdk/python/v1beta1#publish-new-sdk-version-to-pypi ?

iamthebot commented 7 months ago

@andreyvelich will do, kind of busy today but will try and get to it tomorrow.

andreyvelich commented 7 months ago

Absolutely, take your time @iamthebot! Thank you for your contributions!