kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.5k stars 441 forks source link

Support Kubernetes Sidecars for Katib Metrics Collectors #2181

Open andreyvelich opened 1 year ago

andreyvelich commented 1 year ago

Recently Kubernetes added native support for sidecars containers as part of KEP 753: https://github.com/kubernetes/enhancements/pull/3761

We need to discuss if we can improve our architecture to run Katib Metrics Collectors as Kubernetes sidecars. It requires to use initContainer with restartPolicy: Always to run the container as a sidecar.

This feature will be available only in Kubernetes 1.28, but we can start the design discussions now.

Existing problems with Katib Metrics Collectors Sidecar:

cc @kubeflow/wg-automl-leads @tenzen-y @gaocegege @votti

tenzen-y commented 1 year ago

@andreyvelich Thank you for raising this proposal! I agree with you because by supporting the sidecars pattern, we can avoid manually managing the termination of the metrics collector.

https://github.com/kubeflow/katib/blob/master/pkg/metricscollector/v1beta1/common/pns.go.

Also, we might be able to support Istio.

github-actions[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tenzen-y commented 11 months ago

/lifecycle freeze

tenzen-y commented 11 months ago

/lifecycle frozen