search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.49k stars 440 forks source link

fix katib use crds token pipeline trail template guide #2330

Closed Jerry-yz closed 4 months ago

Jerry-yz commented 4 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_: Fixes #

Checklist:

Jerry-yz commented 4 months ago

What this PR does / why we need it: fix document update Use CRDs with Trial Template , but sync here Katib Examples with Tekton Pipelines Integration Which issue(s) this PR fixes _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_: Fixes # fix issue #2327 Checklist:

  • [x] Docs included if any changes are user facing
Jerry-yz commented 4 months ago

Thank you for this update @Jerry-yz! I noticed that we have appropriate steps to support Tekton pipeline with Katib Trial here: https://www.kubeflow.org/docs/components/katib/user-guides/trial-template/#use-crds-with-trial-template Should we just link this guide to the Katib controller section in this doc?

i have update it, you can review it, thanks?

andreyvelich commented 4 months ago

Thank you for your contribution @Jerry-yz! /lgtm /approve

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/katib/blob/master/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andreyvelich commented 4 months ago

@Jerry-yz Please rebase your PR to fix the CI/CD.