search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.49k stars 440 forks source link

Fix Scikit-Learn Version for Skopt Tests #2336

Closed andreyvelich closed 4 months ago

andreyvelich commented 4 months ago

This should fix our CI for skopt suggestion. We are getting this error in the most recent sckit-learn version:

E   ImportError: cannot import name 'check_pandas_support' from 'sklearn.utils' 
(/Users/avelichk/miniconda3/envs/katib-ci/lib/python3.9/site-packages/sklearn/utils/__init__.py)

Eventually, we should deprecate skopt in favour of GPSampler from Optuna: https://github.com/kubeflow/katib/issues/2280#issuecomment-1993658378 for bayesian optimization in Katib.

cc @contramundum53

/assign @kubeflow/wg-training-leads

andreyvelich commented 4 months ago

/approve

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/katib/blob/master/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment