[SDK]Support Docker image as objective in the tune API

kubeflow / katib

Automated Machine Learning on Kubernetes

https://www.kubeflow.org/docs/components/katib

Apache License 2.0

1.49k stars 440 forks source link

[SDK]Support Docker image as objective in the tune API #2338

Open akhilsaivenkata opened 4 months ago

akhilsaivenkata commented 4 months ago

What this PR does / why we need it: Supporting Docker image as an objective in the tune API.

Which issue(s) this PR fixes _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_: Fixes #2326

Checklist:

[ ] Docs included if any changes are user facing

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/katib/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

akhilsaivenkata commented 4 months ago

Hi @andreyvelich , I made the changes to katib_client.py. Do we have any test cases that need to be updated or implemented for this change? I also wanted to test these new changes on my local machine so I ran "make check" & "make test" commands on my local machine and there were no failures. I wonder if you could see and suggest any action items that needs to taken up here.

andreyvelich commented 3 months ago

@akhilsaivenkata Please rebase your PR.

andreyvelich commented 1 month ago

Hi @akhilsaivenkata, did you get a chance to finish this PR ?