search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.45k stars 425 forks source link

Introducing go-install-tool in the Makefile makes it easier to set up the development environment #2347

Open forsaken628 opened 3 weeks ago

forsaken628 commented 3 weeks ago

What this PR does / why we need it: Current development environments use binary tools that are not isolated, which makes switching between projects troublesome and error-prone. We can improve this situation by introducing go-install-tool in the makefile.

alse see: https://github.com/kubernetes-sigs/kubebuilder/blob/98d03bed2912b2f7adf73aeaf5f64fafa8fd927b/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go#L263-L275

Which issue(s) this PR fixes _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_: Fixes #

Checklist:

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/katib/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment