search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.49k stars 440 forks source link

Remove code generation from release script #2363

Closed andreyvelich closed 3 months ago

andreyvelich commented 3 months ago

I removed the code generation from our release script.

Currently, we have to clone Katib repo to the $GOPATH/src/github.com/kubeflow/katib to correctly run Go code generation. However, in the release script we clone the Katib repo to the temp directory to avoid un-sync Git history.

We don't need to run make generate in our release script, since we have the code generation check for each PR.

Also, we don't need to publish images with COMMIT tag during the release.

/assign @tenzen-y @johnugeorge

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/katib/blob/master/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment