search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.51k stars 442 forks source link

Replaced hpcloud with nxadm for tail package in Go #2375

Closed tariq-hasan closed 4 months ago

tariq-hasan commented 4 months ago

What this PR does / why we need it: This issue helps to migrate the dependency of the tail package in katib from https://github.com/hpcloud/tail to https://github.com/nxadm/tail. This change is required because hpcloud has not been maintaining their implementation of the tail package.

Which issue(s) this PR fixes _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_: Fixes https://github.com/kubeflow/katib/issues/2299

Checklist:

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/katib/blob/master/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment