kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.48k stars 439 forks source link

Add e2e test for `tune` in the `katib_client` module #2383

Closed tariq-hasan closed 1 month ago

tariq-hasan commented 1 month ago

What you would like to be added?

We need to add e2e test for the tune function in the katib_client module.

Why is this needed?

References

Source

Related issues

Love this feature?

Give it a 👍 We prioritize the features with most 👍

andreyvelich commented 1 month ago

Thank you for creating this @tariq-hasan! /area sdk /area testing /remove-lifecycle needs-triage /good-first-issue

google-oss-prow[bot] commented 1 month ago

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/katib/issues/2383): >Thank you for creating this @tariq-hasan! >/area sdk >/area testing >/remove-lifecycle needs-triage >/good-first-issue > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kyooosukedn commented 1 month ago

Would like to try on this :)

andreyvelich commented 1 month ago

@kyooosukedn @tariq-hasan Do you time working on this ? I think, it would be great to have some simple test using tune API. We can even take the getting started example: https://www.kubeflow.org/docs/components/katib/getting-started/#getting-started-with-katib-python-sdk

Similar to the Training Operator, we should just add another test to the run-e2e-experiment.py.

kyooosukedn commented 1 month ago

Hi @andreyvelich, sorry that it took me so long to finally work on this.. will do to try replicate this and get working.Thanks for your lead.

andreyvelich commented 1 month ago

Thank you for your time!

Electronic-Waste commented 1 month ago

I will work on this :)

/assign