Open Electronic-Waste opened 3 months ago
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
/remove-lifecycle stale /good-first-issue
@andreyvelich: This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue
command.
As we discuss in issue #2369 , we choose to always pass the Trial name as env variable
KATIB_TRIAL_NAME
to the training container. And we implemented this feature as functionmutatePodEnv
and used it here:https://github.com/kubeflow/katib/blob/206fe1c1065826ae173a4baea002bb34b483aba8/pkg/webhook/v1beta1/pod/inject_webhook.go#L140-L142
Here are some discussions about it: https://github.com/kubeflow/katib/pull/2369#discussion_r1677885344 https://github.com/kubeflow/katib/pull/2369#discussion_r1678669508 https://github.com/kubeflow/katib/pull/2369#discussion_r1681061505
We use this issue to track the discussion. Any suggestions are welcome!