search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.51k stars 441 forks source link

[Discussion] The future of Trial metadata parameters. #2390

Open Electronic-Waste opened 3 months ago

Electronic-Waste commented 3 months ago

As we discuss in issue #2369 , we choose to always pass the Trial name as env variable KATIB_TRIAL_NAME to the training container. And we implemented this feature as function mutatePodEnv and used it here:

https://github.com/kubeflow/katib/blob/206fe1c1065826ae173a4baea002bb34b483aba8/pkg/webhook/v1beta1/pod/inject_webhook.go#L140-L142

Here are some discussions about it: https://github.com/kubeflow/katib/pull/2369#discussion_r1677885344 https://github.com/kubeflow/katib/pull/2369#discussion_r1678669508 https://github.com/kubeflow/katib/pull/2369#discussion_r1681061505

We use this issue to track the discussion. Any suggestions are welcome!

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

andreyvelich commented 2 weeks ago

/remove-lifecycle stale /good-first-issue

google-oss-prow[bot] commented 2 weeks ago

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/katib/issues/2390): >/remove-lifecycle stale >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.