search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.51k stars 443 forks source link

Replace `go mock` with `client-go fake client` in unit tests #2408

Open tariq-hasan opened 3 months ago

tariq-hasan commented 3 months ago

What you would like to be added?

go mock should be replaced with client-go fake client in unit tests.

Why is this needed?

Reference: https://github.com/kubeflow/katib/pull/2289#discussion_r1718769690

Love this feature?

Give it a 👍 We prioritize the features with most 👍

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

andreyvelich commented 1 week ago

/remove-lifecycle stale /good-first-issue /remove-label lifecycle/needs-triage /area testing

google-oss-prow[bot] commented 1 week ago

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/katib/issues/2408): >/remove-lifecycle stale >/good-first-issue >/remove-label lifecycle/needs-triage >/area testing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.