search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.48k stars 439 forks source link

[SDK] Fix the tricky import changes in Python SDK #2416

Open Electronic-Waste opened 2 weeks ago

Electronic-Waste commented 2 weeks ago

What you would like to be added?

This issue is created to track the tricky import changes in Python SDK.

Currently, we have no choice but to do the tricky import changes because: https://github.com/kubeflow/katib/pull/2398#discussion_r1718127482 .

https://github.com/kubeflow/katib/blob/a524f33830e02189476efaf6d9045cbd2ce605f0/Makefile#L169-L179

https://github.com/kubeflow/katib/blob/a524f33830e02189476efaf6d9045cbd2ce605f0/sdk/python/v1beta1/setup.py#L41-L54

Why is this needed?

As I described in https://github.com/kubeflow/katib/pull/2398#discussion_r1725488407 , we need to discard the tricky import changes when https://github.com/protocolbuffers/protobuf/issues/7061 supports options like python_package to mutate the importing package name.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

andreyvelich commented 1 week ago

/remove-label lifecycle/needs-triage /area sdk

tenzen-y commented 1 week ago

@kubeflow/wg-automl-leads Protocol Buffers code generator is extensible. So, TBH, I'm wondering if we can implement custom Python protoc plugin for Katib since it seems that https://github.com/protocolbuffers/protobuf/issues/7061 was opened 4 years ago, and then the issue is not still resolved...