search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.51k stars 443 forks source link

fix(ui): update None Collector with Push Collector. #2418

Open Electronic-Waste opened 2 months ago

Electronic-Waste commented 2 months ago

What this PR does / why we need it:

After we rename None collector to Push collector in https://github.com/kubeflow/katib/pull/2369, we have not updated the UI so far. So I do some changes in the UI package.

Which issue(s) this PR fixes _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_: Fixes #

Checklist:

Electronic-Waste commented 2 months ago

PTAL👀 @kubeflow/wg-automl-leads if you have time.

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/ui/v1beta1/OWNERS](https://github.com/kubeflow/katib/blob/master/pkg/ui/v1beta1/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.

Electronic-Waste commented 2 months ago

I'm sorry that I missed updating some None fields in the code. Now I have replaced all of them.