search

kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.51k stars 443 forks source link

Improve Debuggability in UTs of Trial Controller #2431

Open Electronic-Waste opened 2 months ago

Electronic-Waste commented 2 months ago

What you would like to be added?

Use the propagated gomega instance in replace of func() bool, like code here:

https://github.com/kubeflow/katib/blob/bc09cfd412da9220fcd13c5ff25a55fe86a6622f/pkg/controller.v1beta1/trial/trial_controller_test.go#L303-L314

Why is this needed?

As @tenzen-y described in https://github.com/kubeflow/katib/pull/2394#discussion_r1765558389, it will improve the debuggability of the UTs.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

Electronic-Waste commented 2 months ago

/area testing /good-first-issue /remove-label lifecycle/needs-triage

google-oss-prow[bot] commented 2 months ago

@Electronic-Waste: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/katib/issues/2431): >/area testing >/good-first-issue >/remove-label lifecycle/needs-triage Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Electronic-Waste commented 2 months ago

/assign