kubeflow / katib

Automated Machine Learning on Kubernetes
https://www.kubeflow.org/docs/components/katib
Apache License 2.0
1.51k stars 443 forks source link

Sdk tests with papermill #2448

Open yehudit1987 opened 1 month ago

yehudit1987 commented 1 month ago

What this PR does / why we need it: This PR creates E2E tests for katib examples to run with papermill.

Which issue(s) this PR fixes _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_: Fixes #2417

Checklist:

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/katib/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Electronic-Waste commented 4 weeks ago

/rerun-all

Electronic-Waste commented 4 weeks ago

@yehudit1987 Can you please fix these CI errors?

Electronic-Waste commented 4 weeks ago

@yehudit1987 Can you sign your commits with git commit -s? The DCO checks failed due to this reason.

Electronic-Waste commented 4 weeks ago

FYI, you can check this reference: https://github.com/kubeflow/katib/pull/2448/checks?check_run_id=32215445282

Electronic-Waste commented 3 weeks ago

/rerun-all

YosiElias commented 3 weeks ago

/rerun-all

Electronic-Waste commented 3 weeks ago

/rerun-all

Electronic-Waste commented 3 weeks ago

/rerun-all

Electronic-Waste commented 2 weeks ago

/rerun-all

Electronic-Waste commented 1 week ago

/rerun-all