Open gaocegege opened 5 years ago
/priority p3
We can use https://golang.org/src/encoding/json/decode.go#L187 json.Number.
Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.
Issue-Label Bot is automatically applying the labels:
Label | Probability |
---|---|
area/front-end | 0.83 |
Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.
@gaocegege Is it better than just a simple string
, like we did with metrics values ?
json.Number is a wrapper of string. We can use string, too.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
/lifecycle frozen
/kind feature
Describe the solution you'd like [A clear and concise description of what you want to happen.]
Ref https://github.com/kubernetes-sigs/controller-tools/issues/245
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]