Split test_kf_is_ready into separate functions - Githubissues

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow

Apache License 2.0

181 stars 137 forks source link

Split test_kf_is_ready into separate functions #215

Open jlewi opened 4 years ago

jlewi commented 4 years ago

Related to #57

We have a monolithic test https://github.com/kubeflow/kfctl/blob/c42f9f3498e1a4f57d91f07b95a480b191b6691e/py/kubeflow/kfctl/testing/pytests/kf_is_ready_test.py#L100

That tests that a whole bunch of applications were successfully deployed.

We should split this up so that

Its easy (e.g. in spyglass) to tell what failed 1 We can mark specific applications as flaky or not blocking for presubmits

e.g like we do for katib https://github.com/kubeflow/kfctl/blob/c42f9f3498e1a4f57d91f07b95a480b191b6691e/py/kubeflow/kfctl/testing/pytests/kf_is_ready_test.py#L48

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label	Probability
kind/feature	0.83

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.